cyb70289 commented on issue #37678: URL: https://github.com/apache/arrow/issues/37678#issuecomment-1719631513
> > I wrote a simple kernel exec that checks the nullity only when overflow occurs: > > This is an interesting approach, but it may fall flat if many of the values underlying null entries trigger overflow. Maybe we can mask the value with valid bit to make sure no overflow can happen if either value is invalid? Somthing like: `ok &= AddWithOverflow((*left_it++) & (-left_arr.IsValid(i)), (*right_it++) & (-right_arr.IsValid(i)), out_it++);` Should have stable performance, but guess this may introduce too many instructions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
