amoeba commented on code in PR #38085:
URL: https://github.com/apache/arrow/pull/38085#discussion_r1349261160
##########
r/R/parquet.R:
##########
@@ -43,14 +44,15 @@ read_parquet <- function(file,
# Assembling `props` yourself is something you do with
# ParquetFileReader but not here.
props = ParquetArrowReaderProperties$create(),
+ mmap = TRUE,
Review Comment:
Do we really want to default this to TRUE? I think memory mapping is
generally off by default throughout the codebase.
##########
r/R/parquet.R:
##########
@@ -43,14 +44,15 @@ read_parquet <- function(file,
# Assembling `props` yourself is something you do with
# ParquetFileReader but not here.
props = ParquetArrowReaderProperties$create(),
+ mmap = TRUE,
Review Comment:
Oh, looks like it's already defaulted to TRUE in `ParquetFileReader$create`
so nevermind here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
