pitrou commented on code in PR #38003:
URL: https://github.com/apache/arrow/pull/38003#discussion_r1350418718
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -747,7 +747,7 @@ if(NOT ARROW_GIT_ID)
OUTPUT_STRIP_TRAILING_WHITESPACE)
endif()
if(NOT ARROW_GIT_DESCRIPTION)
- execute_process(COMMAND "git" "describe" "--tags" "--dirty"
+ execute_process(COMMAND "git" "describe" "--tags"
Review Comment:
Are you sure this fixes the issue reliably? Is it just an implementation
detail in git?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
