kou commented on code in PR #38003:
URL: https://github.com/apache/arrow/pull/38003#discussion_r1350790230
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -747,7 +747,7 @@ if(NOT ARROW_GIT_ID)
OUTPUT_STRIP_TRAILING_WHITESPACE)
endif()
if(NOT ARROW_GIT_DESCRIPTION)
- execute_process(COMMAND "git" "describe" "--tags" "--dirty"
+ execute_process(COMMAND "git" "describe" "--tags"
Review Comment:
It's an implementation detail.
The `git describe` document doesn't explain this behavior:
https://git-scm.com/docs/git-describe
Here is the implementation with `--dirty`:
https://github.com/git/git/blob/3a06386e314565108ad56a9bdb8f7b80ac52fb69/builtin/describe.c#L669-L697
It touches `.git/index` (`*_index()` functions are used).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
