ovr commented on pull request #9139:
URL: https://github.com/apache/arrow/pull/9139#issuecomment-757169119


   Thank you, @jorgecarleitao, for your review. I've added tests + fix handling 
null values.
   
   I've compared it with PostgreSQL, and It works as expected.
   
   ```sql
   select
           md5('tom') AS md5_tom,
           md5('') AS md5_empty_str,
           md5(null) AS md5_null,
           encode(sha224('tom'), 'hex') AS sha224_tom,
           encode(sha224(''), 'hex') AS sha224_empty_str,
           sha224(null) AS sha224_null;
   ```
   
   ```json
   [
     {
       "md5_tom": "34b7da764b21d298ef307d04d8152dc5",
       "md5_empty_str": "d41d8cd98f00b204e9800998ecf8427e",
       "md5_null": null,
       "sha224_tom": "0bf6cb62649c42a9ae3876ab6f6d92ad36cb5414e495f8873292be4d",
       "sha224_empty_str": 
"d14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f",
       "sha224_null": null
     }
   ]
   ```
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to