orgadish commented on PR #38144: URL: https://github.com/apache/arrow/pull/38144#issuecomment-1759062236
@paleolimbot @thisisnic I believe the PR is ready for final review -- it's passing all my tests, including the new ones. Two notes/questions: 1. `map_of` does not do a roundtrip because it's represented as `list_of(struct(key, value))` instead of `map_of(key, value)`. Should I change that in this PR? 2. `explicit_pkg_name` seems like a very long argument name -- any ideas of how to shorten? Perhaps `use_ns` or `with_ns` (bool) to match the `.ns` argument (string) in `call2`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
