orgadish commented on code in PR #38144:
URL: https://github.com/apache/arrow/pull/38144#discussion_r1357748460
##########
r/R/type.R:
##########
@@ -665,13 +694,16 @@ list_of <- function(type) list__(type)
LargeListType <- R6Class("LargeListType",
inherit = NestedType,
public = list(
- code = function() {
- call2("large_list_of", self$value_type$code())
+ code = function(explicit_pkg_name = FALSE) {
+ call2(private$call_name(), self$value_type$code(explicit_pkg_name), .ns
= get_pkg_ns(explicit_pkg_name))
}
),
active = list(
value_field = function() LargeListType__value_field(self),
value_type = function() LargeListType__value_type(self)
+ ),
+ private = list(
+ call_name = function() "large_list_of"
Review Comment:
Separating out the `call_name` came from a previous implementation where I
was doing much more complicated things, before I discovered the `.ns` argument
in `call2`. I agree with you that we should revert to the previous setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
