wotbrew opened a new pull request, #38305: URL: https://github.com/apache/arrow/pull/38305
### What changes are included in this PR? Sum the leg counts ahead of internalStruct.getBufferSizeFor calls, as legs can have different lengths. This adds a typeid loop to determine leg membership < count, it'd be nice to find a way to not loop over the type buffer, would welcome suggestions. ### Are these changes tested? Included a test that verifies the OOB read (requires bounds check), and an example count is correct, fails as expected before fix. **This PR contains a "Critical Fix".** For users of DenseUnionVector the size can be completely wrong, as well as cause of out-of-bounds buffer reads which may return garbage (or potentially segfaulting) if bounds checking is off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
