wotbrew commented on code in PR #38305:
URL: https://github.com/apache/arrow/pull/38305#discussion_r1367021448


##########
java/vector/src/main/codegen/templates/DenseUnionVector.java:
##########
@@ -714,8 +714,22 @@ public int getBufferSizeFor(final int count) {
     if (count == 0) {
       return 0;
     }
+
+    int[] legCounts = new int[typeFields.length];

Review Comment:
   Forgive the name 😓, internal team term leakage! 
   
   Fixed by adapting setChildVectorValueCounts (using `counts`)



##########
java/vector/src/main/codegen/templates/DenseUnionVector.java:
##########
@@ -714,8 +714,22 @@ public int getBufferSizeFor(final int count) {
     if (count == 0) {
       return 0;
     }
+
+    int[] legCounts = new int[typeFields.length];

Review Comment:
   Forgive the name 😓, internal team term leakage! 
   
   Fixed by adapting setChildVectorValueCounts (using `counts`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to