viirya commented on code in PR #7969:
URL: https://github.com/apache/arrow-datafusion/pull/7969#discussion_r1375523966
##########
datafusion/common/src/scalar.rs:
##########
@@ -3885,6 +3889,77 @@ mod tests {
);
}
+ #[test]
+ fn scalar_try_from_array_list_array_null() {
+ let list = ListArray::from_iter_primitive::<Int32Type, _, _>(vec![
+ Some(vec![Some(1), Some(2)]),
+ None,
+ ]);
+
+ let non_null_list_scalar = ScalarValue::try_from_array(&list,
0).unwrap();
+ let null_list_scalar = ScalarValue::try_from_array(&list, 1).unwrap();
+
+ assert_eq!(
+ non_null_list_scalar.data_type(),
+ null_list_scalar.data_type()
+ );
+ }
+
+ #[test]
+ fn scalar_try_from_list() {
+ let data_type =
+ DataType::List(Arc::new(Field::new("item", DataType::Int32,
true)));
+ let data_type = &data_type;
+ let scalar: ScalarValue = data_type.try_into().unwrap();
+
+ let expected = ScalarValue::List(new_null_array(
+ &DataType::List(Arc::new(Field::new("item", DataType::Int32,
true))),
+ 1,
+ ));
+
+ assert_eq!(expected, scalar)
+ }
+
+ #[test]
+ fn scalar_try_from_list_of_list() {
+ let data_type = DataType::List(Arc::new(Field::new(
+ "item",
+ DataType::List(Arc::new(Field::new("item", DataType::Int32,
true))),
+ true,
+ )));
+ let data_type = &data_type;
+ let scalar: ScalarValue = data_type.try_into().unwrap();
+
+ let expected = ScalarValue::List(new_null_array(
+ &DataType::List(Arc::new(Field::new(
+ "item",
+ DataType::List(Arc::new(Field::new("item", DataType::Int32,
true))),
+ true,
+ ))),
+ 1,
+ ));
+
+ assert_eq!(expected, scalar)
+ }
+
+ #[test]
+ fn scalar_try_from_not_equal_list_nested_list() {
+ let list_data_type =
+ DataType::List(Arc::new(Field::new("item", DataType::Int32,
true)));
+ let data_type = &list_data_type;
+ let list_scalar: ScalarValue = data_type.try_into().unwrap();
+
+ let nested_list_data_type = DataType::List(Arc::new(Field::new(
+ "item",
+ DataType::List(Arc::new(Field::new("item", DataType::Int32,
true))),
+ true,
+ )));
+ let data_type = &nested_list_data_type;
+ let nested_list_scalar: ScalarValue = data_type.try_into().unwrap();
+
+ assert_ne!(list_scalar, nested_list_scalar);
Review Comment:
Previously the `ScalarValue`s for list and nested list NULL values are
equal, that is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
