tustvold opened a new pull request, #8012:
URL: https://github.com/apache/arrow-datafusion/pull/8012
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #8009
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
See ticket, the current behaviour is inconsistent and makes it impossible to
address files with percent encoded paths. This was introduced in
https://github.com/apache/arrow-datafusion/pull/3750 and works well for paths
that don't contain percent encoded sequences, however, the behaviour is
problematic for those that do.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This changes ListingTableUrl to treat the provided URLs as URL-encoded. The
implications of this are:
* Users relying on percent encoding of non-URL safe characters, e.g.
unicode, will need to do this themselves
* URLs containing percent encoded '%' characters, i.e. `%25` will now have
consistent behaviour
The ticket alluded to an approach used by some systems whereby it just takes
the URL path verbatim, however, I had difficulty finding a way to get `Url` to
play ball, as it insists on hewing the URL specification which doesn't allow
for this. In general I think it is probably better to follow the actual
specification, especially given the current behaviour is sufficiently broken
I'm confident there aren't many people relying on it.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
