ozankabak commented on PR #8047: URL: https://github.com/apache/arrow-datafusion/pull/8047#issuecomment-1793380626
BTW this is a first step towards improving comments and finding a better name/place for the `PartitionSearchMode` struct as discussed in https://github.com/apache/arrow-datafusion/pull/8006#discussion_r1380428109 @alamb, given that this struct simply encodes whether a given set of expressions have a partial or full permutation satisfying the ordering of a table, should we give it a more generic name like `OrderedPermutation`? If we do that, we probably would want to change the variant names to something like `None`, `Partial` and `Full` too. If we general-purposify this struct in this manner, where do you think this struct definition should be? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
