paleolimbot commented on code in PR #38571:
URL: https://github.com/apache/arrow/pull/38571#discussion_r1383386058
##########
r/tools/nixlibs.R:
##########
@@ -828,10 +832,10 @@ quietly <- !env_is("ARROW_R_DEV", "true")
not_cran <- env_is("NOT_CRAN", "true")
-if (is_release) {
+if (is_release & !test_mode) {
VERSION <- VERSION[1, 1:3]
arrow_repo <- paste0(getOption("arrow.repo",
sprintf("https://apache.jfrog.io/artifactory/arrow/r/%s";, VERSION)),
"/libarrow/")
-} else {
+} else if(!test_mode) {
Review Comment:
I think most of the distracting output is fixed in
https://github.com/apache/arrow/pull/38534 even with sourcing the script
(output here:
https://github.com/apache/arrow/actions/runs/6746935491/job/18341961924?pr=38534#step:5:23756
). Is there any part of that output that could be improved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
