assignUser commented on code in PR #38571:
URL: https://github.com/apache/arrow/pull/38571#discussion_r1384223549
##########
r/tools/nixlibs.R:
##########
@@ -828,10 +832,10 @@ quietly <- !env_is("ARROW_R_DEV", "true")
not_cran <- env_is("NOT_CRAN", "true")
-if (is_release) {
+if (is_release & !test_mode) {
VERSION <- VERSION[1, 1:3]
arrow_repo <- paste0(getOption("arrow.repo",
sprintf("https://apache.jfrog.io/artifactory/arrow/r/%s";, VERSION)),
"/libarrow/")
-} else {
+} else if(!test_mode) {
Review Comment:
I also just used the existing pattern so :shrug: I think it should be fine
to fix it like this as further up is a block that sets the version specifically
for testing and iirc we don't use the arrow repo option in any of the tests
(other wise we would also see fails in ci).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
