lidavidm commented on code in PR #38385:
URL: https://github.com/apache/arrow/pull/38385#discussion_r1388064707


##########
cpp/src/arrow/flight/sql/types.h:
##########
@@ -119,6 +119,14 @@ struct ARROW_FLIGHT_SQL_EXPORT SqlInfoOptions {
     /// If 0, there is no timeout.
     FLIGHT_SQL_SERVER_TRANSACTION_TIMEOUT = 101,
 
+    /// Retrieves a boolean value indicating whether the Flight SQL Server
+    /// supports executing bulk ingestion.
+    FLIGHT_SQL_SERVER_BULK_INGESTION = 102,
+
+    /// Retrieves a boolean value indicating whether the Flight SQL Server
+    /// supports transactions for bulk ingestion.
+    FLIGHT_SQL_SERVER_INGEST_TRANSACTIONS_SUPPORTED = 103,

Review Comment:
   Sorry, I just realized I was looking at a different part of the file. I 
don't recall why we jumped to 100 originally. But since 100 and 101 are 
timeouts we could make these new codes 10 and 11 instead of 102 and 103. Is 
that better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to