2010YOUY01 commented on PR #8148:
URL:
https://github.com/apache/arrow-datafusion/pull/8148#issuecomment-1811962384
Thank you! The implementation looks good to me, one minor suggestion is to
add some empty string cases to sqllogictest like `select string_agg('', '|'),
string_agg('a', '');`
Also adopting test cases from mature systems like Postgres/Duckdb is a
really good idea 👍🏼 , we should encourage contributors to do so when adding new
functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
