comphead commented on code in PR #8283:
URL: https://github.com/apache/arrow-datafusion/pull/8283#discussion_r1400080866
##########
datafusion/sql/src/planner.rs:
##########
@@ -230,6 +231,41 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
Ok(Schema::new(fields))
}
+ pub(super) fn build_column_defaults(
Review Comment:
would be nice to explain in comments what exactly gets returned in the tuple
for future readers, like `<column name, expr>`
I'm even thinking should be that be a map instead of `Vec<>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
