qrilka commented on code in PR #8291:
URL: https://github.com/apache/arrow-datafusion/pull/8291#discussion_r1402002752
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -973,6 +982,24 @@ fn create_schema(
Ok(Schema::new(fields))
}
+/// returns schema with dictionary group keys materialized as their value types
+/// The actual convertion happens in `RowConverter` and we don't do unnecessary
+/// conversion back into dictionaries
+fn materialize_dict_group_keys(schema: &Schema, group_count: usize) -> Schema {
Review Comment:
I'll take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
