qrilka commented on code in PR #8291:
URL: https://github.com/apache/arrow-datafusion/pull/8291#discussion_r1404293897
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -973,6 +982,24 @@ fn create_schema(
Ok(Schema::new(fields))
}
+/// returns schema with dictionary group keys materialized as their value types
+/// The actual convertion happens in `RowConverter` and we don't do unnecessary
+/// conversion back into dictionaries
+fn materialize_dict_group_keys(schema: &Schema, group_count: usize) -> Schema {
Review Comment:
@alamb I do understand your point and it saw this when creating my PR but I
don't quite see a good way around this: the problem is that `GroupValues` get's
created only during execution in `AggregateExec::execute_typed` but the correct
("materialized") schema looks to be needed in `AggregateExec` itself, i.e.
already at the planning stage (as a part of `impl ExecutionPlan for
AggregateExec`).
Maybe I miss some option here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
