tustvold commented on code in PR #5110:
URL: https://github.com/apache/arrow-rs/pull/5110#discussion_r1406064361
##########
parquet/src/column/writer/mod.rs:
##########
@@ -2891,6 +2938,158 @@ mod tests {
assert!(incremented.is_none())
}
+ #[test]
+ fn test_boundary_order() -> Result<()> {
+ let descr = Arc::new(get_test_column_descr::<Int32Type>(1, 0));
+ // min max both ascending
+ let column_close_result = write_multiple_pages::<Int32Type>(
+ &descr,
+ &[
+ &[Some(-10), Some(10)],
+ &[Some(-5), Some(11)],
+ &[None],
Review Comment:
Is there some documentation of this behaviour in the parquet spec, or
failing that an example implementation doing similar. Normally I would have
expected a null to break the ordering as it would break the ability to do
binary search
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
