Jefffrey commented on code in PR #5110:
URL: https://github.com/apache/arrow-rs/pull/5110#discussion_r1406735823
##########
parquet/src/column/writer/mod.rs:
##########
@@ -2891,6 +2938,158 @@ mod tests {
assert!(incremented.is_none())
}
+ #[test]
+ fn test_boundary_order() -> Result<()> {
+ let descr = Arc::new(get_test_column_descr::<Int32Type>(1, 0));
+ // min max both ascending
+ let column_close_result = write_multiple_pages::<Int32Type>(
+ &descr,
+ &[
+ &[Some(-10), Some(10)],
+ &[Some(-5), Some(11)],
+ &[None],
Review Comment:
There is this example test in arrow c++ that shows null pages doesn't have
an effect on ordering:
https://github.com/apache/arrow/blob/862792132297f0ca519c83e524e59c7d685298e8/cpp/src/parquet/arrow/arrow_reader_writer_test.cc#L5597-L5610
Same here:
https://github.com/apache/arrow/blob/84c15da1997559c37841dc16f9e2c70c643dd9d2/cpp/src/parquet/page_index_test.cc#L567-L581
Though I do agree that the Parquet spec is lacking explicit documentation on
how null pages are handled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
