tustvold commented on code in PR #5135:
URL: https://github.com/apache/arrow-rs/pull/5135#discussion_r1408353398
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -572,7 +572,15 @@ impl<T> std::fmt::Debug for ParquetRecordBatchStream<T> {
}
impl<T> ParquetRecordBatchStream<T> {
- /// Returns the [`SchemaRef`] for this parquet file
+ /// Returns the [`SchemaRef`] for this parquet file.
+ ///
+ /// Note that unlike its synchronous counterpart
[`ParquetRecordBatchReader`], the [`SchemaRef`]
+ /// returned here will contain the original metadata, whereas
[`ParquetRecordBatchReader`]
+ /// strips this metadata.
Review Comment:
Oh this is the stream not the builder :facepalm:
Yeah we should probably be returning the same schema as the RecordBatch we
return, sorry for the confusion... Could you revert your revert, sorry too many
plates at the moment :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
