mapleFU commented on code in PR #38863:
URL: https://github.com/apache/arrow/pull/38863#discussion_r1409119364
##########
cpp/src/parquet/bloom_filter_reader_test.cc:
##########
@@ -25,31 +25,41 @@
namespace parquet::test {
TEST(BloomFilterReader, ReadBloomFilter) {
- std::string dir_string(parquet::test::get_data_dir());
- std::string path = dir_string + "/data_index_bloom_encoding_stats.parquet";
- auto reader = ParquetFileReader::OpenFile(path, false);
- auto file_metadata = reader->metadata();
- EXPECT_FALSE(file_metadata->is_encryption_algorithm_set());
- auto& bloom_filter_reader = reader->GetBloomFilterReader();
- auto row_group_0 = bloom_filter_reader.RowGroup(0);
- ASSERT_NE(nullptr, row_group_0);
- EXPECT_THROW(bloom_filter_reader.RowGroup(1), ParquetException);
- auto bloom_filter = row_group_0->GetColumnBloomFilter(0);
- ASSERT_NE(nullptr, bloom_filter);
- EXPECT_THROW(row_group_0->GetColumnBloomFilter(1), ParquetException);
+ struct BloomFilterTestFile {
+ std::string filename;
+ bool has_bloom_filter_length;
+ };
+ std::vector<BloomFilterTestFile> files = {
+ {"data_index_bloom_encoding_stats.parquet", false},
+ {"data_index_bloom_encoding_with_length.parquet", false},
Review Comment:
Hmmm this is unused, because it will handled by `BloomFilterReader` internal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
