pitrou commented on code in PR #38863:
URL: https://github.com/apache/arrow/pull/38863#discussion_r1409217559
##########
cpp/src/parquet/bloom_filter.cc:
##########
@@ -136,6 +144,14 @@ BlockSplitBloomFilter BlockSplitBloomFilter::Deserialize(
bloom_filter.Init(header_buf->data() + header_size, bloom_filter_size);
return bloom_filter;
}
+ if (bloom_filter_length && *bloom_filter_length != bloom_filter_size +
header_size) {
+ // We know the bloom filter data size, but the real size is different.
+ std::stringstream ss;
+ ss << "Bloom filter length (" << bloom_filter_length.value()
+ << ") is not enough to read the entire bloom filter (size: "
+ << bloom_filter_size + header_size << ").";
Review Comment:
```suggestion
ss << "Bloom filter length (" << bloom_filter_length.value()
<< ") does not match the actual bloom filter (size: "
<< bloom_filter_size + header_size << ").";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
