Tom-Newton commented on PR #36627: URL: https://github.com/apache/arrow/pull/36627#issuecomment-1836908650
I think I've addressed all the specific comments. > We might want to move the python CacheOptions class from _dataset.pyx to eg io.pxi and expose it top-level in pyarrow (instead of in the dataset module). Because this options class can also be accepted in pure IPC or Parquet readers outside of the Datasets API (which itself certainly doesn't need to be done in this PR) I will try to do this tomorrow. > Do we want to expose MakeFromNetworkMetrics as well? Could be a classmethod like CacheOptions.from_network_metrics Personally I don't have a need for it but probably it would be a good thing to do. I will look into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
