Tom-Newton commented on code in PR #36627:
URL: https://github.com/apache/arrow/pull/36627#discussion_r1412657259
##########
python/pyarrow/_dataset.pyx:
##########
@@ -1963,6 +1963,100 @@ cdef class FragmentScanOptions(_Weakrefable):
except TypeError:
return False
+cdef class CacheOptions(_Weakrefable):
+ """
+ Cache options for a pre-buffered fragment scan.
+ Parameters
+ ----------
+ hole_size_limit : int, default 8Ki
+ The maximum distance in bytes between two consecutive ranges; beyond
+ this value, ranges are not combined.
+ range_size_limit : int, default 32Mi
+ The maximum size in bytes of a combined range; if combining two
+ consecutive ranges would produce a range of a size greater than this,
+ they are not combined
+ lazy : bool, default False
+ A lazy cache does not perform any I/O until requested.
Review Comment:
Thanks @mapleFU. I altered the wording a bit compared to your suggestion but
I've updated the comments on the python and C++. If you would rather I go with
your suggestion word for word, then I don't mind changing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
