alamb commented on code in PR #8424:
URL: https://github.com/apache/arrow-datafusion/pull/8424#discussion_r1416244437
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -435,13 +427,16 @@ macro_rules! slice {
.zip($EXTRA_KEY.iter())
.map(|((arr, i), j)| match (arr, i, j) {
(Some(arr), Some(i), Some(j)) => {
- list_slice!(arr, i, j, $RETURN_ELEMENT, $ARRAY_TYPE)
+ let arr =
arr.as_any().downcast_ref::<$ARRAY_TYPE>().unwrap();
Review Comment:
since `list_slice` takes a `array: &dyn Array,` already, is it possible to
avoid the `arr.as_any().downcast_ref...` call and just pass `arr` directly to
`list_slice`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
