paleolimbot commented on code in PR #330: URL: https://github.com/apache/arrow-nanoarrow/pull/330#discussion_r1417598425
########## extensions/nanoarrow_ipc/src/apps/integration_test_util.cc: ########## @@ -0,0 +1,219 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <cerrno> +#include <deque> +#include <iostream> +#include <string> +#include <unordered_map> +#include <utility> + +#include "nanoarrow/nanoarrow_ipc.hpp" +#include "nanoarrow/nanoarrow_testing.hpp" + +void print_help() { + std::cerr << "nanoarrow version " << ArrowNanoarrowVersion() << "\n"; + std::cerr << " Usage: integration_test_util convert\n"; + std::cerr << " --from [json|ipc] [file or -]\n"; + std::cerr << " [[--to [json] [-]] OR [--check [json|ipc] [file or -]]]\n"; +} + +class ArgumentParser { Review Comment: I removed this file for now (snapshotted here: https://gist.github.com/paleolimbot/ec2a2067198f0de1901c107c783d3b26 )...`bash` + this is probably not how these tests should run in the repo. I'll do another PR for this...the IPC tests already have something set up to read the IPC files from the testing repo and it might be easiest just to put these tests there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
