lidavidm commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1425852873
##########
java/pom.xml:
##########
@@ -870,7 +897,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
- <argLine>--add-opens=java.base/java.nio=ALL-UNNAMED</argLine>
+
<argLine>--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED</argLine>
Review Comment:
Just to be sure, do we still need ALL-UNNAMED?
##########
java/memory/memory-core/pom.xml:
##########
@@ -54,6 +53,30 @@
</build>
<profiles>
+ <profile>
+ <id>error-prone-jdk11+</id>
Review Comment:
how is this profile related to ErrorProne?
##########
java/memory/memory-unsafe/src/test/java/org/apache/arrow/memory/unsafe/TestUnsafeAllocationManager.java:
##########
@@ -15,20 +15,25 @@
* limitations under the License.
*/
-package org.apache.arrow.memory;
+package org.apache.arrow.memory.unsafe;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
+import org.apache.arrow.memory.AllocationManager;
+import org.apache.arrow.memory.ArrowBuf;
+import org.apache.arrow.memory.BufferLedger;
+import org.apache.arrow.memory.RootAllocator;
+import org.apache.arrow.memory.unsafe.UnsafeAllocationManager;
import org.junit.Test;
/**
* Test cases for {@link UnsafeAllocationManager}.
*/
public class TestUnsafeAllocationManager {
- private BaseAllocator createUnsafeAllocator() {
- return new
RootAllocator(BaseAllocator.configBuilder().allocationManagerFactory(UnsafeAllocationManager.FACTORY)
+ private RootAllocator createUnsafeAllocator() {
Review Comment:
Ideally we never refer to RootAllocator (or BaseAllocator) as a type, only
BufferAllocator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
