jorisvandenbossche commented on code in PR #39272:
URL: https://github.com/apache/arrow/pull/39272#discussion_r1431095106
##########
cpp/src/arrow/util/formatting_util_test.cc:
##########
@@ -522,6 +522,28 @@ TEST(Formatting, Timestamp) {
AssertFormatting(formatter, -2203932304LL * 1000000000LL + 8,
"1900-02-28 12:34:56.000000008");
}
+
+ {
+ auto timestamp_types = {timestamp(TimeUnit::SECOND, "US/Eastern"),
+ timestamp(TimeUnit::SECOND, "+01:00"),
+ timestamp(TimeUnit::SECOND, "-42:00"),
+ timestamp(TimeUnit::SECOND, "Pacific/Maruesas"),
+ timestamp(TimeUnit::SECOND,
"Mars/Mariner_Valley")};
Review Comment:
Can you also test with different resolutions?
(it might not be needed to test the whole list of values below for each
type, we maybe can also just test one of them per resolution/tz outside of a
loop, if that makes things simpler)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
