jeroen edited a comment on pull request #9321:
URL: https://github.com/apache/arrow/pull/9321#issuecomment-767183967


   Few comments: 
   
    - You can use `withr::with_locale()` to simplify temporary setting the 
locale
    - Most servers won't have the Japanese language pack installed, so 
`Sys.setlocale("LC_COLLATE", "Japanese")` may fail
    - The bug is that the procedure takes very long to complete, but it 
succeed, eventually. Hence I'm not sure this test will detect the problem 
properly, or just that your tests will be taking super long to complete.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to