wjones127 commented on code in PR #39380:
URL: https://github.com/apache/arrow/pull/39380#discussion_r1448245330
##########
python/pyarrow/tests/test_cffi.py:
##########
@@ -414,6 +414,37 @@ def test_export_import_batch_reader(reader_factory):
pa.RecordBatchReader._import_from_c(ptr_stream)
+@needs_cffi
+def test_export_import_exception_reader():
+ c_stream = ffi.new("struct ArrowArrayStream*")
+ ptr_stream = int(ffi.cast("uintptr_t", c_stream))
+
+ gc.collect() # Make sure no Arrow data dangles in a ref cycle
+ old_allocated = pa.total_allocated_bytes()
+
+ def gen():
+ if True:
+ try:
+ raise ValueError('foo')
+ except ValueError as e:
+ raise NotImplementedError('bar') from e
+ else:
+ yield from make_batches()
+
+ original = pa.RecordBatchReader.from_batches(make_schema(), gen())
+ original._export_to_c(ptr_stream)
+
+ reader = pa.RecordBatchReader._import_from_c(ptr_stream)
+ with pytest.raises(OSError) as exc_info:
+ reader.read_next_batch()
+
+ # inner *and* outer exception should be present
+ assert 'ValueError: foo' in str(exc_info.value)
+ assert 'NotImplementedError: bar' in str(exc_info.value)
Review Comment:
Thanks, that is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
