pitrou commented on code in PR #39380:
URL: https://github.com/apache/arrow/pull/39380#discussion_r1448497227
##########
python/pyarrow/src/arrow/python/common.cc:
##########
@@ -131,6 +138,34 @@ class PythonErrorDetail : public StatusDetail {
}
protected:
+ Result<std::string> FormatImpl() const {
+ PyAcquireGIL lock;
+
+ // Use traceback.format_exception()
+ OwnedRef traceback_module;
+ RETURN_NOT_OK(internal::ImportModule("traceback", &traceback_module));
+
+ OwnedRef fmt_exception;
+ RETURN_NOT_OK(internal::ImportFromModule(traceback_module.obj(),
"format_exception",
+ &fmt_exception));
+
+ OwnedRef formatted;
+ formatted.reset(PyObject_CallFunctionObjArgs(fmt_exception.obj(),
exc_type_.obj(),
+ exc_value_.obj(),
exc_traceback_.obj(),
+ NULL));
+
+ std::stringstream ss;
+ ss << "Python exception: ";
+ Py_ssize_t num_lines = PyList_GET_SIZE(formatted.obj());
Review Comment:
> I assume the function calls will do the type checking internally, correct?
If you're using the concrete `PyList` APIs, they will generally assume that
it is a list object (there is no hard rule unfortunately). Also, fast access
macros such as `PyList_GET_ITEM` don't do any error checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
