comphead commented on code in PR #8823:
URL: https://github.com/apache/arrow-datafusion/pull/8823#discussion_r1449412953
##########
datafusion/physical-expr/src/planner.rs:
##########
@@ -43,29 +43,17 @@ use std::sync::Arc;
/// * `e` - The logical expression
/// * `input_dfschema` - The DataFusion schema for the input, used to resolve
`Column` references
/// to qualified or unqualified fields by name.
-/// * `input_schema` - The Arrow schema for the input, used for determining
expression data types
-/// when performing type coercion.
pub fn create_physical_expr(
e: &Expr,
input_dfschema: &DFSchema,
- input_schema: &Schema,
Review Comment:
it should be okay, if difference happen by any reason, we usually hit the
error on planning `Error during planning: Mismatch between schema and batches`
Like below
https://github.com/apache/arrow-datafusion/issues/5695#issuecomment-1483877234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
