kou commented on code in PR #39524:
URL: https://github.com/apache/arrow/pull/39524#discussion_r1449625106
##########
r/tools/nixlibs.R:
##########
@@ -860,7 +860,8 @@ if (is_release) {
VERSION <- VERSION[1, 1:3]
arrow_repo <- paste0(getOption("arrow.repo",
sprintf("https://apache.jfrog.io/artifactory/arrow/r/%s";, VERSION)),
"/libarrow/")
} else {
- not_cran <- TRUE
+ # Don't override explictily set NOT_CRAN env var, as it is used in CI.
+ not_cran <- TRUE && !env_is("NOT_CRAN", "false")
Review Comment:
Ah, we have `not_cran <- env_is("NOT_CRAN", "true")` in the above line.
We may be able to simplify this like the following:
```diff
diff --git a/r/tools/nixlibs.R b/r/tools/nixlibs.R
index fe8de284b1..e89b814512 100644
--- a/r/tools/nixlibs.R
+++ b/r/tools/nixlibs.R
@@ -854,13 +854,12 @@ on_windows <- tolower(Sys.info()[["sysname"]]) ==
"windows"
# For local debugging, set ARROW_R_DEV=TRUE to make this script print more
quietly <- !env_is("ARROW_R_DEV", "true")
-not_cran <- env_is("NOT_CRAN", "true")
+not_cran <- !env_is("NOT_CRAN", "false")
if (is_release) {
VERSION <- VERSION[1, 1:3]
arrow_repo <- paste0(getOption("arrow.repo",
sprintf("https://apache.jfrog.io/artifactory/arrow/r/%s";, VERSION)),
"/libarrow/")
} else {
- not_cran <- TRUE
arrow_repo <- paste0(getOption("arrow.dev_repo",
"https://nightlies.apache.org/arrow/r";), "/libarrow/")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
