jonkeane commented on code in PR #39587:
URL: https://github.com/apache/arrow/pull/39587#discussion_r1451557749
##########
r/inst/build_arrow_static.sh:
##########
@@ -74,6 +74,8 @@ ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-DARROW_DATASET=${ARROW_DATASET:-ON} \
-DARROW_DEPENDENCY_SOURCE=${ARROW_DEPENDENCY_SOURCE:-AUTO} \
-DAWSSDK_SOURCE=${AWSSDK_SOURCE:-} \
+ -DBoost_SOURCE=${BOOST_SOURCE:-} \
+ -Dlz4_SOURCE=${LZ4_SOURCE:-} \
Review Comment:
Happy to change these — they are currently all caps due to the comment above
this one: https://github.com/apache/arrow/pull/39587/files#r1450998393
We have separate code that is demanding all env vars are supposed to be all
caps, so I just fit into that paradigm (and for a smaller patch) but I'm happy
to remove that here and now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
