jonkeane commented on code in PR #39587:
URL: https://github.com/apache/arrow/pull/39587#discussion_r1451558137
##########
r/tools/nixlibs.R:
##########
@@ -539,10 +562,25 @@ build_libarrow <- function(src_dir, dst_dir) {
env_var_list <- c(env_var_list, ARROW_DEPENDENCY_SOURCE = "BUNDLED")
}
+ # On macOS, if not otherwise set, let's override Boost_SOURCE to be bundled
+ if (on_macos) {
+ deps_to_bundle <- c("Boost", "lz4")
+ for (dep_to_bundle in deps_to_bundle) {
+ env_var <- paste0(dep_to_bundle, "_SOURCE")
+ if (Sys.getenv(env_var) == "") {
Review Comment:
Given kou's comment (and my incoming changes to use the mix-case version) I
think I'll keep this as mixed case to match the (current) cmake args. I
probably should also add this to the documentation of our build variables in
the package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
