zanmato1984 commented on code in PR #39383: URL: https://github.com/apache/arrow/pull/39383#discussion_r1456139818
########## cpp/src/arrow/compute/light_array.cc: ########## @@ -19,7 +19,9 @@ #include <type_traits> +#include "arrow/array/builder_binary.h" Review Comment: Well, there is a pitfall about `BaseBinaryBuilder::memory_limit()` - it's `std::numeric_limits<int32_t>::max() - 1`. I only noticed this til my initial test failed. So I thought it might be necessary to keep using `BaseBinaryBuilder::memory_limit()` to avoid the potential mismatch. Does that make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
