zanmato1984 commented on code in PR #39383:
URL: https://github.com/apache/arrow/pull/39383#discussion_r1456360732
##########
cpp/src/arrow/compute/light_array_test.cc:
##########
@@ -407,6 +408,63 @@ TEST(ExecBatchBuilder, AppendValuesBeyondLimit) {
ASSERT_EQ(0, pool->bytes_allocated());
}
+TEST(ExecBatchBuilder, AppendVarLengthBeyondLimit) {
+ std::unique_ptr<MemoryPool> owned_pool = MemoryPool::CreateDefault();
+ MemoryPool* pool = owned_pool.get();
+ constexpr auto eight_mb = 8 * 1024 * 1024;
+ std::string str_8mb(eight_mb, 'a');
+ std::string str_8mb_minus_1(eight_mb - 1, 'b');
+ std::string str_8mb_minus_2(eight_mb - 2,
+ 'b'); // BaseBinaryBuilder::memory_limit()
Review Comment:
I was trying to use this string to be the last element of an array that
occupies exactly `memory_limit()` bytes. Unfortunately it is not a good
comment. My bad. I'll change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
