vibhatha commented on code in PR #39529:
URL: https://github.com/apache/arrow/pull/39529#discussion_r1462672450


##########
java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/ArrowFlightStatementExecuteUpdateTest.java:
##########
@@ -207,9 +207,12 @@ public void 
testShouldFailToPrepareStatementForBadStatement() {
        * we simply throw an `IllegalArgumentException` for queries not 
registered
        * in our `MockFlightSqlProducer`.
        */
+      String expectedMessage = format("Error while executing SQL \"%s\": " +
+          "org.apache.arrow.flight.FlightRuntimeException: INVALID_ARGUMENT: 
Query not found",

Review Comment:
   Resolved: happened because of overriding `getMessage` instead of `toString` 



##########
java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/ArrowFlightStatementExecuteUpdateTest.java:
##########
@@ -207,9 +207,12 @@ public void 
testShouldFailToPrepareStatementForBadStatement() {
        * we simply throw an `IllegalArgumentException` for queries not 
registered
        * in our `MockFlightSqlProducer`.
        */
+      String expectedMessage = format("Error while executing SQL \"%s\": " +
+          "org.apache.arrow.flight.FlightRuntimeException: INVALID_ARGUMENT: 
Query not found",

Review Comment:
   Will be pushing this next. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to