bkietz commented on a change in pull request #9294:
URL: https://github.com/apache/arrow/pull/9294#discussion_r565498799
##########
File path: r/tests/testthat/test-compute-arith.R
##########
@@ -18,32 +18,31 @@
test_that("Addition", {
a <- Array$create(c(1:4, NA_integer_))
expect_type_equal(a, int32())
- expect_type_equal(a + 4, int32())
- expect_equal(a + 4, Array$create(c(5:8, NA_integer_)))
- expect_identical(as.vector(a + 4), c(5:8, NA_integer_))
+ expect_type_equal(a + 4L, int32())
+ expect_type_equal(a + 4, float64())
+ expect_equal(a + 4L, Array$create(c(5:8, NA_integer_)))
+ expect_identical(as.vector(a + 4L), c(5:8, NA_integer_))
expect_equal(a + 4L, Array$create(c(5:8, NA_integer_)))
expect_vector(a + 4L, c(5:8, NA_integer_))
expect_equal(a + NA_integer_, Array$create(rep(NA_integer_, 5)))
- # overflow errors — this is slightly different from R's `NA` coercion when
- # overflowing, but better than the alternative of silently restarting
- casted <- a$cast(int8())
- expect_error(casted + 127)
- expect_error(casted + 200)
+ a8 <- a$cast(int8())
+ expect_type_equal(a8 + Scalar$create(1, int8()), int8())
+ expect_type_equal(a8 + 127L, int32())
+ expect_type_equal(a8 + 200L, int32())
Review comment:
will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
