guojidan commented on issue #8965: URL: https://github.com/apache/arrow-datafusion/issues/8965#issuecomment-1907683887
> As @haohuaijin notes we may want to update > > https://github.com/apache/arrow-datafusion/blob/e642cc2a94f38518d765d25c8113523aedc29198/datafusion/physical-expr/src/expressions/not.rs#L83-L92 > > to not check for `is_null` I think we still need check `is_null`, because `get_casted_expr_for_bool_op` will convert `null` to `ScalarValue::Boolean(NULL)`, but `ScalarValue::Boolean(NULL)` can not `try_into()` to `bool` type, so it will throw an error: Internal error: Cannot convert Boolean(NULL) to bool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
