jayzhan211 commented on code in PR #8902:
URL: https://github.com/apache/arrow-datafusion/pull/8902#discussion_r1469501615
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -577,19 +578,14 @@ fn coerce_arguments_for_fun(
let mut expressions: Vec<Expr> = expressions.to_vec();
- // Cast Fixedsizelist to List for array functions
- if *fun == BuiltinScalarFunction::MakeArray {
+ // coerce the fixed size list to list for all array fucntions
+ if fun.name().contains("array") {
Review Comment:
Because any kind of array functions includes make_array(). Like
`array_append(cast(fixedsizelist, list), element)`. we dont need to check again
with `array_append`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
