pitrou commented on code in PR #39975:
URL: https://github.com/apache/arrow/pull/39975#discussion_r1482661318
##########
cpp/src/arrow/memory_pool.cc:
##########
@@ -195,7 +195,7 @@ bool IsDebugEnabled() {
return false;
}
auto env_value = *std::move(maybe_env_value);
- if (env_value.empty()) {
+ if (env_value.empty() || env_value == "none") {
Review Comment:
Can you add a test for this somewhere in
https://github.com/apache/arrow/blob/main/python/pyarrow/tests/test_memory.py#L246?
Also, this value could be documented in
https://github.com/apache/arrow/blob/main/docs/source/cpp/env_vars.rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
