jduo commented on code in PR #1495:
URL: https://github.com/apache/arrow-adbc/pull/1495#discussion_r1483588584
##########
java/driver/flight-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/InfoMetadataBuilder.java:
##########
@@ -145,7 +150,12 @@ VectorSchemaRoot build() throws AdbcException {
root.setRowCount(dstIndex);
VectorSchemaRoot result = root;
- root = null;
+ try {
+ root = VectorSchemaRoot.create(StandardSchemas.GET_INFO_SCHEMA,
allocator);
Review Comment:
Why does an empty root get recreated here?
FYI I'm reworking some of this code for the getObjects() impl. Planning to
make this class an Iterator<VectorSchemaRoots> and have RootArrowReader consume
the iterator to avoid front-loading the client when there are lots of metadata
objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
