viirya commented on code in PR #40043:
URL: https://github.com/apache/arrow/pull/40043#discussion_r1488629362
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java:
##########
@@ -476,11 +507,12 @@ private void allocateBytes(final long valueBufferSize,
final int valueCount) {
}
/* allocate offset buffer */
- private void allocateOffsetBuffer(final long size) {
+ private ArrowBuf allocateOffsetBuffer(final long size) {
Review Comment:
For 2, this is only for exporting the vectors through C Data Interface. By
its means, it is intended to be released by the importer side. At Java Arrow, I
remember ArrayExporter only increases the reference count for the buffers to be
exported to prevent them to be released automatically.
And the release callback of exported structure will reduce the reference
count to release it eventually. But it is triggered at imported side. I think
this is what the C Data Interface defines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
