lidavidm commented on code in PR #40043:
URL: https://github.com/apache/arrow/pull/40043#discussion_r1488637713
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java:
##########
@@ -476,11 +507,12 @@ private void allocateBytes(final long valueBufferSize,
final int valueCount) {
}
/* allocate offset buffer */
- private void allocateOffsetBuffer(final long size) {
+ private ArrowBuf allocateOffsetBuffer(final long size) {
Review Comment:
I think Antoine's idea was that you could statically allocate one such
buffer to use in such situations, if you're talking about this
> As long as data stays internal to Arrow Java, the missing buffer is ok,
but for purposes of exchanging data, a proper offsets buffers should be
exported (this one can easily be statically allocated, by the way).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
