viirya commented on code in PR #40043:
URL: https://github.com/apache/arrow/pull/40043#discussion_r1488742575
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java:
##########
@@ -476,11 +507,12 @@ private void allocateBytes(final long valueBufferSize,
final int valueCount) {
}
/* allocate offset buffer */
- private void allocateOffsetBuffer(final long size) {
+ private ArrowBuf allocateOffsetBuffer(final long size) {
Review Comment:
Hmm, I think I got your point. But I am wondering if it makes sense. I doubt
that after exporting an array, it still makes sense to hold and modify it at
exported side.
Especially,
https://arrow.apache.org/docs/format/CDataInterface.html#mutability
> Both the producer and the consumer SHOULD consider the exported data (that
is, the data reachable through the buffers member of ArrowArray) to be
immutable, as either party could otherwise see inconsistent data while the
other is mutating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
