viirya commented on code in PR #40043:
URL: https://github.com/apache/arrow/pull/40043#discussion_r1488744172
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java:
##########
@@ -476,11 +507,12 @@ private void allocateBytes(final long valueBufferSize,
final int valueCount) {
}
/* allocate offset buffer */
- private void allocateOffsetBuffer(final long size) {
+ private ArrowBuf allocateOffsetBuffer(final long size) {
Review Comment:
If you insist that the offset buffer must keep same buffer between Java
Arrow and exported side. The only way is to set it (the one value offset) to
the offset of the vector. But as I said before, it will cause a lot
inconsistency in Java Arrow.
I don't think an inconsistent offset (sometimes it is empty sometimes it is
one value buffer) is a good idea. Very confused and easy to cause bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
