Weijun-H commented on code in PR #9108:
URL: https://github.com/apache/arrow-datafusion/pull/9108#discussion_r1494205691
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -4296,10 +4384,10 @@ select
array_ndims(column4)
from array_ndims_table;
----
-0 1 2 5
-0 1 2 5
-0 1 2 5
-0 1 2 5
+1 1 2 5
+1 1 2 5
+NULL 1 2 5
Review Comment:
I testes these cases in PostgreSQL, so I think it should not be a error here
```
**Schema (PostgreSQL v15)**
CREATE TABLE array_ndims_table (
arr_data int[]
);
INSERT INTO array_ndims_table (arr_data)
VALUES
(array[1]),
(array[2]),
(null);
---
**Query #1**
SELECT array_ndims(arr_data) AS array_dimensions
FROM array_ndims_table;
| array_dimensions |
| ---------------- |
| 1 |
| 1 |
| |
---
[View on DB Fiddle](https://www.db-fiddle.com/)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
